]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
shellDBus: Return error from ReloadExtension
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 28 Mar 2020 17:55:17 +0000 (18:55 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Sat, 28 Mar 2020 22:14:44 +0000 (22:14 +0000)
The method has been deprecated because it generally doesn't (and
can't) work. Clarify that by returning an error instead of
apparently doing nothing.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2510

js/ui/shellDBus.js

index 2b6b2ae9646f2b80b7e23518d91a5e05b0ce7111..f64081b24a287b63cef5ad93c1bfe7d062d7f027 100644 (file)
@@ -329,12 +329,11 @@ var GnomeShellExtensions = class {
             (conn, res) => conn.call_finish(res));
     }
 
-    ReloadExtension(uuid) {
-        let extension = Main.extensionManager.lookup(uuid);
-        if (!extension)
-            return;
-
-        Main.extensionManager.reloadExtension(extension);
+    ReloadExtensionAsync(params, invocation) {
+        invocation.return_error_literal(
+            Gio.DBusError,
+            Gio.DBusError.NOT_SUPPORTED,
+            'ReloadExtension is deprecated and does not work');
     }
 
     CheckForUpdates() {